Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inject): Clear buffer before writing sourcemap #1525

Merged
merged 2 commits into from Mar 15, 2023
Merged

Conversation

loewenheim
Copy link
Contributor

Writing to a vector of bytes does not overwrite it, it appends. Thus, when injecting a debug id into a sourcemap file, we must clear the buffer before writing the modified contents.

Fixes #1524.

@loewenheim loewenheim self-assigned this Mar 15, 2023
@loewenheim loewenheim merged commit f07d193 into master Mar 15, 2023
16 checks passed
@loewenheim loewenheim deleted the fix/inject-clear branch March 15, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with sentry-cli@2.15.0 and the sourcemaps injection feature (#1504)
2 participants