Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Allow multiple paths in sourcemaps inject #1523

Merged
merged 4 commits into from Mar 15, 2023
Merged

ref: Allow multiple paths in sourcemaps inject #1523

merged 4 commits into from Mar 15, 2023

Conversation

loewenheim
Copy link
Contributor

The second commit slightly changes the inject tests to use multiple paths.

This is required for getsentry/sentry-react-native#2892

@loewenheim loewenheim self-assigned this Mar 15, 2023
kamilogorek
kamilogorek approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@kamilogorek kamilogorek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A wording nit (need to update test snapshots as well)

src/commands/sourcemaps/inject.rs Outdated Show resolved Hide resolved
loewenheim and others added 2 commits March 15, 2023 17:27
@loewenheim @kamilogorek
Update src/commands/sourcemaps/inject.rs
cc140a3 
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
@loewenheim
update snapshot
e5f2467
@kamilogorek kamilogorek merged commit c9e5eea into master Mar 15, 2023
16 checks passed
@kamilogorek kamilogorek deleted the ref/inject-paths branch March 15, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees

@loewenheim loewenheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loewenheim @kamilogorek