feat: Inject debug ids into source and sourcemap files before uploading #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
requested review from
kamilogorek and
Swatinem
and removed request for
kamilogorek
Swatinem
reviewed
Mar 9, 2023
Swatinem
approved these changes
Mar 9, 2023
kamilogorek
force-pushed
the
ref/inject-print
branch
from
b489bed
to
7ee60bb
Compare
kamilogorek
force-pushed
the
feat/upload-inject
branch
from
23212f3
to
f6c4c8d
Compare
Hidden for now. |
kamilogorek
pushed a commit
that referenced
this pull request
Mar 13, 2023
kamilogorek
pushed a commit
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that debug ids are injected into source files and sourcemaps before uploading. A
--no-injectflag is provided to disable this behavior.As a refactoring, most of the injection logic is moved into a new module under
utils/sourcemaps. This may be easier to understand by looking at the commits individually.Questions:
--no-injectflag be hidden?upload.rs?