Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: also distribute sentry-cli as a pip package #1494

Merged
merged 1 commit into from Mar 1, 2023
Merged

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Feb 28, 2023

this packages up this binary as something that's pip installable -- hopefully making the setup process easier and not relying on the uptime of github packages or the sentry cdn for installation

how this works:

  1. build a sdist and wheel from source (mostly to demonstrate that building from source works for unsupported platforms)
  2. download the prebuilt artifacts that we distribute through github releases
  3. stitch the prebuilt binaries into wheels, adjusting the platform tag to match

(this saves building everything twice, and ensures that identical binaries are present independent of how it installs)

I've also pushed this to release/just-testing so I can validate that the build works (it should show in this PR too!)

$ ./venv/bin/pip install y/sentry_cli-2.13.0-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl 
Processing ./y/sentry_cli-2.13.0-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
Installing collected packages: sentry-cli
Successfully installed sentry-cli-2.13.0
$ ./venv/bin/sentry-cli --version
sentry-cli 2.13.0

Copy link
Member

@mitsuhiko mitsuhiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Longer term would be nice not to have a setup.py here but I'm totally okay with this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants