Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement new chunk based upload for standalone artifact bundles #1490

Merged
merged 22 commits into from Mar 10, 2023

Conversation

mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented Feb 23, 2023

This implements the necessary changes to permit standalone artifact bundle uploads. The idea is that we check in the chunk upload options to see if we can perform a new style upload and otherwise fall back to release creation and source file upload.

  • very old sentry versions did not have global releases, sentry-cli still supports that. This makes some of the existing code read a bit odd
  • releases can be created without projects (an antipattern that the UI does not support)
  • new style artifact bundles require at least one project to be set, otherwise we fall back to the old logic
  • the uploader only supports one project to be passed rather than a list

To do:

  • embed an ID directly in the artifact bundle
  • add tests

Refs getsentry/sentry#44885

src/api.rs Show resolved Hide resolved
src/utils/sourcemaps.rs Show resolved Hide resolved
src/utils/sourcemaps.rs Outdated Show resolved Hide resolved
src/utils/sourcemaps.rs Outdated Show resolved Hide resolved
src/utils/sourcemaps.rs Outdated Show resolved Hide resolved
@kamilogorek
Copy link
Contributor

LGTM. I don't like few parts, but we've got to work with what we have :P

src/utils/file_upload.rs Outdated Show resolved Hide resolved
src/utils/sourcemaps.rs Show resolved Hide resolved
mitsuhiko and others added 2 commits March 10, 2023 14:57
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
@mitsuhiko mitsuhiko enabled auto-merge (squash) March 10, 2023 13:58
@mitsuhiko mitsuhiko merged commit 35ab7d3 into master Mar 10, 2023
16 checks passed
@mitsuhiko mitsuhiko deleted the feature/new-chunk-upload branch March 10, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants