-
-
Notifications
You must be signed in to change notification settings - Fork 229
feat: Implement new chunk based upload for standalone artifact bundles #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+421
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
reviewed
Mar 6, 2023
kamilogorek
reviewed
Mar 6, 2023
kamilogorek
reviewed
Mar 6, 2023
kamilogorek
reviewed
Mar 6, 2023
mitsuhiko
commented
Mar 8, 2023
kamilogorek
reviewed
Mar 8, 2023
kamilogorek
reviewed
Mar 8, 2023
kamilogorek
approved these changes
Mar 8, 2023
LGTM. I don't like few parts, but we've got to work with what we have :P |
Swatinem
approved these changes
Mar 8, 2023
kamilogorek
reviewed
Mar 10, 2023
kamilogorek
reviewed
Mar 10, 2023
kamilogorek
reviewed
Mar 10, 2023
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the necessary changes to permit standalone artifact bundle uploads. The idea is that we check in the chunk upload options to see if we can perform a new style upload and otherwise fall back to release creation and source file upload.
To do:
Refs getsentry/sentry#44885