feat(monitors): Pass SENTRY_TRACE_ID down execution path #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
suggested changes
Jan 27, 2023
src/commands/monitors/run.rs
Outdated
Comment on lines
63
to
65
| // Inherit outer SENTRY_TRACE_ID if present | ||
| if env::var_os("SENTRY_TRACE_ID").is_none() { | ||
| p.env("SENTRY_TRACE_ID", trace_id.to_string().replace("-", "")); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| // Inherit outer SENTRY_TRACE_ID if present | |
| if env::var_os("SENTRY_TRACE_ID").is_none() { | |
| p.env("SENTRY_TRACE_ID", trace_id.to_string().replace("-", "")); | |
| } | |
| // Inherit outer SENTRY_TRACE_ID if present | |
| let trace_id = env::var_os("SENTRY_TRACE_ID").unwrap_or_else(|| Uuid::new_v4().simple().to_string()); | |
| p.env("SENTRY_TRACE_ID", trace_id); | |
There was a problem hiding this comment.
Please check if it compiles correctly, as I wrote it directly in a suggestion 😅
There was a problem hiding this comment.
Also run make lint and make format.
src/commands/monitors/run.rs
Outdated
Comment on lines
46
to
47
| let trace_id = Uuid::new_v4(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| let trace_id = Uuid::new_v4(); |
kamilogorek
force-pushed
the
evanpurkhiser/feat-monitors-pass-sentry-trace-id-down-execution-path
branch
from
089b78f
to
b0c09df
Compare
kamilogorek
approved these changes
Jan 30, 2023
kamilogorek
deleted the
evanpurkhiser/feat-monitors-pass-sentry-trace-id-down-execution-path
branch
|
Oh wait, I wasn't ready to merge this hahaha |
|
Oh, then it should be a draft 🌝 but no harm done, as it's a self-contained change and will not break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
SENTRY_TRACE_IDto the environ of the executing command.This is in support of getsentry/sentry#43647
and will allow SDKs embedded in the executing command to associate the
monitor checkin to any events produced by the SDK.
This is the second part of #1438