Prevent Sentry from attempting to access unbound variables #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Maybe someone from Sentry should have a look at this, before my PR is closed automatically due to inactivity... |
|
@LeonMelis I missed that one as I'm on vacation the whole of December, will take a look at it after the new year. Cheers. |
|
Makes perfect sense, thanks! |
Bash has a nifty feature `set -u` to error on unbound variables. This is also trappable (like with `set -e`), so Sentry can catch this. However, Sentry itself may attempt to access arguments via `$1` and `$2`, which may not be set, which will trigger a bash error if `set -u` is used. This will create an error output: `./my_script.sh: line 42: $1: unbound variable`. The proposed fix here will check for existence of `$1...$n` via the argument count `$#`, without accessing `$1...$n`, making it possible to use Sentry for bash scripts with `set -u`
kamilogorek
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bash has a nifty feature
set -uto error on unbound variables. This is also trappable (like withset -e), so Sentry can catch this.However, Sentry itself may attempt to access arguments via
$1and$2, which may not be set, which will trigger a bash error ifset -uis used. This will create an error output:./my_script.sh: line 42: $1: unbound variable.The proposed fix here will check for existence of
$1...$nvia the argument count$#, without accessing$1...$n, making it possible to use Sentry for bash scripts withset -u