feat(dist): Add limit validation #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we limit the lenght of the incoming distribution name, which should not be longer than 64 characters, which is enforced on the DB side. This change just adds the validation as closer to the user as possible.
jjbayer
reviewed
Nov 4, 2022
| } else if v.len() > 64 { | ||
| Err( | ||
| "Invalid distribution name. Distribution name must not be longer than 64 characters." | ||
| .to_string(), |
There was a problem hiding this comment.
This gets me thinking, how do we handle unicode characters? They might exceed string length 64 even if the number of characters is lower. I assume that the limit enforced on sentry side is applied to the number of characters, not the number of bytes.
There was a problem hiding this comment.
Very good point! On the relay side we use bytecount::num_chars and check the actual bytes. We might want to do here similar.
|
Looks good. Can you update unicode handling mentioned above? As for lint errors, they should be resolved on master now. |
|
@kamilogorek done, PTAL! |
|
I've canceled the CI since there is a test which does not progress. This test is stuck on my mac laptop as well: |
|
No worries, fixed it |
kamilogorek
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we limit the length of the incoming distribution name, which should not be longer than 64 characters, which is enforced on the DB side.
This change just adds the validation as closer to the user as possible.
related: getsentry/relay#1556