Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List issues #1349

Merged
merged 16 commits into from Jul 20, 2023
Merged

List issues #1349

merged 16 commits into from Jul 20, 2023

Conversation

boozec
Copy link
Contributor

@boozec boozec commented Oct 5, 2022

Hi all 👋
with this PR I suggest to add the sentry issues list command to show the list of issues bases on a query. This is similar to events list but showed as below:

sentry-cli issues list --query="is:unresolved"
+------------+-----------+------------------------+-----------------------------+------------+-------+
| Issue ID   | Short ID  | Title                  | Last seen                   | Status     | Level |
+------------+-----------+------------------------+-----------------------------+------------+-------+
| 1          | SE-API-1  | Example                | 2022-10-05T00:00.856565Z    | unresolved | error |
+------------+-----------+------------------------+-----------------------------+------------+-------+

#skip-changelog

@github-actions
Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me, I missed that PR entirely. Will merge it once all patches are in place. Thanks for the contribution!

src/api.rs Outdated Show resolved Hide resolved
src/api.rs Outdated Show resolved Hide resolved
src/api.rs Outdated Show resolved Hide resolved
let org = config.get_org(matches)?;
let project = config.get_project(matches)?;
let pages = *matches.get_one("pages").unwrap();
let query = match matches.get_one::<String>("query") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once query is changed to Option, there'll be no need to match it here.

register_test("issues/issues-list-help.trycmd");
}

#[test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add some "working" tests as well? Maybe with flags behavior that you added as well? :)

@boozec boozec requested a review from kamilogorek July 19, 2023 18:37
@kamilogorek kamilogorek merged commit 3e81cb3 into getsentry:master Jul 20, 2023
16 checks passed
@kamilogorek
Copy link
Contributor

Lovely, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants