Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paths argument for debug-files find should take a value #1346

Merged
merged 1 commit into from Oct 3, 2022

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Oct 3, 2022

NOTE: takes_name implicitly sets Arg::takes_value(true)

Whoops.

#no-changelog

@kamilogorek kamilogorek requested a review from a team October 3, 2022 11:39
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- paths argument for debug-files find should take a value ([#1346](https://github.com/getsentry/sentry-cli/pull/1346))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 3778f96

@kamilogorek
Copy link
Contributor Author

Ugh, I need to disable danger. Changelogs in CLI are collected automatically.

@kamilogorek kamilogorek merged commit 91a9371 into master Oct 3, 2022
@kamilogorek kamilogorek deleted the find-take-value branch October 3, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants