Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Log warning when debug source excedes item size limit #1305

Merged
merged 1 commit into from Aug 4, 2022

Conversation

kamilogorek
Copy link
Contributor

This will produce the warning below:

WARN    2022-08-04 12:32:50.920489 +02:00 Source exceded maximum item size limit (116303). /Applications/Xcode.app/usr/include/c++/v1/chrono
WARN    2022-08-04 12:32:50.961811 +02:00 Source exceded maximum item size limit (103509). /Applications/Xcode.app/usr/include/c++/v1/atomic
WARN    2022-08-04 12:32:50.980145 +02:00 Source exceded maximum item size limit (157727). /Applications/Xcode.app/usr/include/c++/v1/type_traits
WARN    2022-08-04 12:32:51.003650 +02:00 Source exceded maximum item size limit (169525). /Applications/Xcode.app/usr/include/c++/v1/string
WARN    2022-08-04 12:32:51.056923 +02:00 Source exceded maximum item size limit (112450). /Applications/Xcode.app/usr/include/c++/v1/vector

Question is, whether we should leave it as WARN, which is on by default, or make it DEBUG, which is opt-in.
I'm not sure how common this case is, and don't want the logs to get cluttered too much.

cc @bruno-garcia

resolves #1304
ref getsentry/sentry-unity#920 (comment)

@kamilogorek kamilogorek requested a review from a team August 4, 2022 10:37
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m okay with making this a warning, as it prompts people to fix their config, or makes it very obvious why they don’t get source context for that file

@kamilogorek kamilogorek merged commit c7f85ab into master Aug 4, 2022
@kamilogorek kamilogorek deleted the filter-warning branch August 4, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print warnings when skipping files due to settings
2 participants