Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add decompress flag to sourcemaps and files upload #1277

Merged
merged 3 commits into from Jul 12, 2022

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Jul 12, 2022

Passing --decompress to either sourcemaps upload or files upload will now detect and recompress gzip files and exact their contents before uploading.

As a nice side-effect, we don't get cannot find source-map reference errors from symbolic, as it correctly matches them too.

In addition to this change, few minor cleanups:

  • remove FileContents enum and use &[u8] directly, to skip a layer of indirection
  • make upload_release_file accept UploadContext to reduce number of arguments passed to this function
  • remove upload_release_files which was not used

This feature will allow getsentry/sentry-webpack-plugin#195 to be resolved.

image

@kamilogorek kamilogorek requested review from mitsuhiko and a team July 12, 2022 11:32
@kamilogorek kamilogorek enabled auto-merge (squash) July 12, 2022 13:15
@kamilogorek kamilogorek merged commit 79f4c9c into master Jul 12, 2022
@kamilogorek kamilogorek deleted the decompress-gzip-artifacts branch July 12, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants