feat: Use checksum to dedupe uploaded release artifacts #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Jul 11, 2022
src/utils/sourcemaps.rs
Outdated
Comment on lines
178
to
182
| /// Adds an already uploaded sources checksum. | ||
| pub fn add_already_uploaded_source(&mut self, checksum: Digest) -> Result<()> { | ||
| self.already_uploaded_sources.push(checksum); | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
Why does this method return a result? It doesn't look like it can fail in any way.
There was a problem hiding this comment.
Good call. Forgot to change that after moving from HashSet which looked like overkill.
loewenheim
approved these changes
Jul 11, 2022
AbhiPrasad
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make
sentry-cliskip the upload of files that are already present for the given release.It's using
sha1checksum for comparison, as we already have this data for every file that was uploaded to our servers.When skipped, an appropriate message is added to the upload report.
The same behavior already exists for all other debug files formats.