Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS2451: Cannot redeclare block-scoped variable #249

Open
3 tasks done
matthew2564 opened this issue Oct 24, 2022 · 18 comments
Open
3 tasks done

TS2451: Cannot redeclare block-scoped variable #249

matthew2564 opened this issue Oct 24, 2022 · 18 comments

Comments

@matthew2564
Copy link

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/angular

SDK Version

7.16.0

Framework Version

Angular 13.3.11 & Ionic 6.3.2

Link to Sentry event

No response

Steps to Reproduce

Node.js v16.10.x

Typescript 4.5.x

Currently we are using the following versions of Sentry package:
"@sentry/angular": "^6.19.7",
"@sentry/capacitor": "^0.6.1",
"@sentry/tracing": "^6.19.7"

After trying to bump all packages to latest i.e.:
"@sentry/angular": "^7.16.0",
"@sentry/capacitor": "^0.10.1",
"@sentry/tracing": "^7.16.0"

Expected Result

No error

Actual Result

I receive the following error:

Error: node_modules/@sentry/types/types/globals.d.ts:2:11 - error TS2451: Cannot redeclare block-scoped variable '__DEBUG_BUILD__'.

2     const __DEBUG_BUILD__: boolean;
            ~~~~~~~~~~~~~~~

  node_modules/@sentry/tracing/node_modules/@sentry/types/types/globals.d.ts:2:11
    2     const __DEBUG_BUILD__: boolean;
                ~~~~~~~~~~~~~~~
    '__DEBUG_BUILD__' was also declared here.
@AbhiPrasad AbhiPrasad transferred this issue from getsentry/sentry-javascript Oct 24, 2022
@lucas-zimerman
Copy link
Collaborator

To fix this you must use a fixed sibling version of angular and tracing

"@sentry/angular": "7.13.0",
"@sentry/capacitor": "0.10.1",
"@sentry/tracing": "7.13.0"

Additionally, at the moment the SDK is compatible with version 7.13.0.

Hopefully this situation will get clearer on the next versions of Sentry Capacitor

@lucas-zimerman
Copy link
Collaborator

By the way, what if when updating the Sentry packages you would get a message like this

This version of Sentry Capacitor is incompatible with the following installed packages:
@sentry/angular version 7.13.0
@sentry/vue version 7.13.0
Please install the mentioned packages with exactly with version 7.15.0 using the below command.
yarn add --exact @sentry/angular@7.15.0 @sentry/vue@7.15.0 

Would that be a convenient way of telling you what to do in order to update those packages? (also a similar message if you were using npm for package management)

Ideally it should work out of the box, but unfortunately, it's how the SDK behaves when there's a duplicated sibling package.

@lforst
Copy link
Member

lforst commented Oct 25, 2022

I am backlogging this for the JS SDK team because I'd like to fix this more sustainably. Right now we're polluting the global typescript namespace with the JS SDK.

Here is the origin of the problem: getsentry/sentry-javascript#5155 (comment) (Note to self: What looks fishy, probably is)

@matthew2564
Copy link
Author

Just to let you know, fixing the versions as specified above does work - thank you @lucas-zimerman.

@lnovelli
Copy link

Had a very similar issue. I was using @sentry/electron 4.1.2 and realized it was relying on @sentry/types 7.16.0 under the hood. After I explicitly added @sentry/types 7.16.0 to my packages.json it worked like a charm.

@iborschca
Copy link

npm install --save-exact @sentry/angular@7.16.0 --update-sentry-capacitor

@Lilja
Copy link

Lilja commented Feb 28, 2023

Is it only compatible with 7.13.0 or 7.13.0 and later? I'm having trouble with my node modules @sentry/types being 7.31.0.

Click to expand logs
node_modules/@sentry/types/types/globals.d.ts:2:11 - error TS2451: Cannot redeclare block-scoped variable '__DEBUG_BUILD__'.

2     const __DEBUG_BUILD__: boolean;
            ~~~~~~~~~~~~~~~

  node_modules/pino-sentry-breadcrumbs/node_modules/@sentry/types/types/globals.d.ts:2:11
    2     const __DEBUG_BUILD__: boolean;
                ~~~~~~~~~~~~~~~
    '__DEBUG_BUILD__' was also declared here.

node_modules/pino-sentry-breadcrumbs/node_modules/@sentry/types/types/globals.d.ts:2:11 - error TS2451: Cannot redeclare block-scoped variable '__DEBUG_BUILD__'.

2     const __DEBUG_BUILD__: boolean;
            ~~~~~~~~~~~~~~~

  node_modules/@sentry/types/types/globals.d.ts:2:11
    2     const __DEBUG_BUILD__: boolean;
                ~~~~~~~~~~~~~~~
    '__DEBUG_BUILD__' was also declared here.


Found 2 errors in 2 files.

Errors  Files
     1  node_modules/@sentry/types/types/globals.d.ts:2
     1  node_modules/pino-sentry-breadcrumbs/node_modules/@sentry/types/types/globals.d.ts:2

@lforst
Copy link
Member

lforst commented Mar 1, 2023

To fix this right now all versions of the sentry packages should be aligned. So if you're on 7.13.0 you need @sentry/types to be on 7.31.0.

@zarko-tg
Copy link

zarko-tg commented May 8, 2023

Getting same/similar build error on a Ionic 6 / Angular 16 / Capacitor 4 project. Trying to move from @sentry/angular to @sentry/angular-ivy.
Dependencies used:
"@sentry/angular-ivy": "^7.51.2"
"@sentry/capacitor": "^0.11.3"

[ng] Error: node_modules/@sentry/capacitor/node_modules/@sentry/types/types/globals.d.ts:2:11 - error TS2451: Cannot redeclare block-scoped variable '__DEBUG_BUILD__'.
[ng]
[ng] 2     const __DEBUG_BUILD__: boolean;
[ng]             ~~~~~~~~~~~~~~~
[ng]
[ng]   node_modules/@sentry/types/types/globals.d.ts:2:11
[ng]     2     const __DEBUG_BUILD__: boolean;
[ng]                 ~~~~~~~~~~~~~~~
[ng]     '__DEBUG_BUILD__' was also declared here.
[ng]
[ng]
[ng] Error: node_modules/@sentry/types/types/globals.d.ts:2:11 - error TS2451: Cannot redeclare block-scoped variable '__DEBUG_BUILD__'.
[ng]
[ng] 2     const __DEBUG_BUILD__: boolean;
[ng]             ~~~~~~~~~~~~~~~
[ng]
[ng]   node_modules/@sentry/capacitor/node_modules/@sentry/types/types/globals.d.ts:2:11
[ng]     2     const __DEBUG_BUILD__: boolean;
[ng]                 ~~~~~~~~~~~~~~~
[ng]     '__DEBUG_BUILD__' was also declared here.

@chutzemischt
Copy link

@zarko-tg If you use @sentry/capacitor v0.11.3 you can't use the latest @sentry/angular-ivy version. The version of @sentry/angular-ivy must match the version used by the @sentry/capacitor library, so in this case 7.50.0. Se also the release notes: https://github.com/getsentry/sentry-capacitor/releases/tag/0.11.3.

@zarko-tg
Copy link

@chutzemischt I think the problem is that support for Angular 16 comes only with 7.51.0.

@chutzemischt
Copy link

@zarko-tg zarko-tg

You're right, Angular 16 support comes officially with 7.51.0. Didn't saw that. I've a project which is running with Angular 16 and following versions of sentry:

"@sentry/angular-ivy": "7.50.0"
"@sentry/capacitor": "0.11.3"

Of course the legacy-peer-deps has to be set to true.

@zarko-tg
Copy link

This is still a problem, so I opened a new case:
#394

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2023
@lforst lforst reopened this Jul 24, 2023
@bruno-garcia
Copy link
Member

bruno-garcia commented Nov 25, 2023

I just hit this problem, Angular 15, build was working fine last I touched this, just changed some unrelated files (outside the SPA) and CI is broken but build locally. Sentry 7.81.1

error TS2451: Cannot redeclare block-scoped variable 'DEBUG_BUILD'.

https://github.com/dotnet/nuget-trends/actions/runs/6990848438/job/19020769563?pr=245

I'm using "@sentry-internal/feedback": "0.0.1-alpha.13", (it's not a capacitor app sorry to pile on this issue)

Any tips how to resolve this? (For now I removed the feedback package)

@lforst
Copy link
Member

lforst commented Nov 27, 2023

@bruno-garcia We can fix this upstream. I'll start working on it today!

@lforst
Copy link
Member

lforst commented Nov 28, 2023

@lucas-zimerman @bruno-garcia We fixed this upstream in the latest JS SDK release so once we update everything this error should be gone for good.

@bruno-garcia
Copy link
Member

Thanks Luca! I'll test it on nuget trends the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

9 participants