Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip jar processing on AGP < 7.1.2 if it is a signed multi release jaโ€ฆ #334

Merged
merged 11 commits into from Jul 5, 2022

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Jun 27, 2022

๐Ÿ“œ Description

Detect signed multi release jars and let the user know that these cause problems and that they should upgrade to AGP >= 7.1.2

๐Ÿ’ก Motivation and Context

Fixes #309

๐Ÿ’š How did you test it?

Added TestCase to ensure that a signed jar is not touched by the transform.

๐Ÿ“ Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

๐Ÿ”ฎ Next steps

Add Entry to Android Troubleshooting Guide

@lbloder
Copy link
Collaborator Author

lbloder commented Jun 29, 2022

@romtsn Thanks for reviewing this.
Implemented your suggestions.
Also, when doing a manual Test I found that it resulted in a Build Error. This is now fixed, also added a testcase to SentryPluginMRJarTest.

@lbloder lbloder requested a review from romtsn June 29, 2022 10:50
@lbloder lbloder marked this pull request as ready for review June 29, 2022 10:50
@lbloder lbloder requested a review from adinauer as a code owner June 29, 2022 10:50
@romtsn
Copy link
Member

romtsn commented Jun 29, 2022

sorry my suggestion caused the formatting to fail ๐Ÿ™ˆ

@lbloder
Copy link
Collaborator Author

lbloder commented Jun 30, 2022

sorry my suggestion caused the formatting to fail ๐Ÿ™ˆ

:D no worries, should be fixed now.

Any idea on the Test Publishing UUID job failing? Seems to be failing on main as well: https://github.com/getsentry/sentry-android-gradle-plugin/actions/runs/2583945350

@romtsn
Copy link
Member

romtsn commented Jun 30, 2022

Yeah, I'm certain that the problem resides in the new sentry-cli version, because from the logs it says:

> Found 12 debug information files
> Resolved source code for 4 debug information files
> Prepared debug information files for upload
> Nothing to upload, all files are on the server

I feel like there was a new feature introduced, where we check if the files are already on the server before uploading it, hence we don't get the Uploaded X missing debug information files. @kamilogorek is that a correct assumption^?

@kamilogorek
Copy link

We had this feature for as long as I can remember. Not sure why it didn't duplicate those files before ๐Ÿ‘€

@romtsn
Copy link
Member

romtsn commented Jul 5, 2022

So 2.3.0 seem to have fixed it, merging in then :)

@romtsn romtsn merged commit 6b5bcd9 into main Jul 5, 2022
@romtsn romtsn deleted the bug/metainf-strip-transform-signed-mrjars branch July 5, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetaInfStripTransform issue with signed jars
3 participants