New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip jar processing on AGP < 7.1.2 if it is a signed multi release jaโฆ #334
Conversation
โฆr, show warning to the user with hint to upgrade AGP
plugin-build/src/main/kotlin/io/sentry/android/gradle/transforms/MetaInfStripTransform.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/test/kotlin/io/sentry/android/gradle/transforms/MetaInfStripTransformTest.kt
Outdated
Show resolved
Hide resolved
โฆentryPluginMRJarTest
# Conflicts: # CHANGELOG.md
@romtsn Thanks for reviewing this. |
plugin-build/src/main/kotlin/io/sentry/android/gradle/transforms/MetaInfStripTransform.kt
Outdated
Show resolved
Hide resolved
โฆms/MetaInfStripTransform.kt
sorry my suggestion caused the formatting to fail ๐ |
:D no worries, should be fixed now. Any idea on the Test Publishing UUID job failing? Seems to be failing on main as well: https://github.com/getsentry/sentry-android-gradle-plugin/actions/runs/2583945350 |
Yeah, I'm certain that the problem resides in the new sentry-cli version, because from the logs it says:
I feel like there was a new feature introduced, where we check if the files are already on the server before uploading it, hence we don't get the |
We had this feature for as long as I can remember. Not sure why it didn't duplicate those files before ๐ |
So 2.3.0 seem to have fixed it, merging in then :) |
๐ Description
Detect signed multi release jars and let the user know that these cause problems and that they should upgrade to AGP >= 7.1.2
๐ก Motivation and Context
Fixes #309
๐ How did you test it?
Added TestCase to ensure that a signed jar is not touched by the transform.
๐ Checklist
๐ฎ Next steps
Add Entry to Android Troubleshooting Guide