Fix: Ignore R8 minified libs from instrumentation #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
May 12, 2022
...n-build/src/main/kotlin/io/sentry/android/gradle/instrumentation/util/ConstantPoolHelpers.kt
Show resolved
Hide resolved
marandaneto
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
Ignore R8-minified libs from instrumentation by looking at the constant pool of a .class file and search for the R8 marker. This uses a lot of reflection, but should be fine because it's done on JVM and not Android. Still, I filed an issue on AGP's tracker, maybe they provide and API for that, so we can avoid reflection.
馃挕 Motivation and Context
Closes #315
馃挌 How did you test it?
Manually on a sample project and automatically
馃摑 Checklist
馃敭 Next steps