Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obfuscated libs instrumentation (adcolony) #307

Merged
merged 2 commits into from Apr 12, 2022
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 12, 2022

馃摐 Description

  • Fix another edge-case with obfuscate library (use of uninitialized instance)

Discussed this with Bruno - it's fine to ship it as part of a new 3.1.0-beta.1 (which we anyway wanted to release and promote on wizard to prompt users for auto-installation). Also, to avoid craft issues when releasing from a tag rather than main.

馃挕 Motivation and Context

Closes #304

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

If this happens again we should prioritize #306 over the new issues to unblock users without disabling entire auto-instrumentation.

@romtsn romtsn merged commit bb412d3 into main Apr 12, 2022
@romtsn romtsn deleted the fix/adcolony-instr branch April 12, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index -1 out of bounds for length 0 (AdColony + io.michaelrocks.paranoid ? )
2 participants