Add SentryOkHttpInterceptor instrumentation #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
commented
Mar 7, 2022
.../android-instrumentation-sample/src/main/java/io/sentry/samples/instrumentation/SampleApp.kt
Show resolved
Hide resolved
romtsn
commented
Mar 7, 2022
.../android-instrumentation-sample/src/main/java/io/sentry/samples/instrumentation/SampleApp.kt
Show resolved
Hide resolved
romtsn
commented
Mar 7, 2022
plugin-build/buildSrc/src/main/kotlin/io/sentry/android/gradle/internal/ASMifyTask.kt
Show resolved
Hide resolved
marandaneto
reviewed
Mar 8, 2022
...id-instrumentation-sample/src/main/java/io/sentry/samples/instrumentation/ui/MainActivity.kt
Show resolved
Hide resolved
romtsn
force-pushed
the
feat/okhttp-instrumentation
branch
from
22cdb51
to
f7fa89b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
馃摐 Description
SentryOkHttpInterceptorto OkHttp requests. We instrument the okhttp library itself, therefore covering all okhttp clients within the app. We also check for the presence of SentryOkHttpInterceptor in the interceptor list, to make sure we do not instrument multiple times馃挕 Motivation and Context
Closes #222 (apollo out of scope)
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps