New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add auto-installation for sentry-android SDK and integrations #282
Conversation
|
...ild/src/main/kotlin/io/sentry/android/gradle/autoinstall/fragment/FragmentInstallStrategy.kt
Outdated
Show resolved
Hide resolved
...n-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/timber/TimberInstallStrategy.kt
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryPlugin.kt
Outdated
Show resolved
Hide resolved
5fd8a35
to
9d57ee0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm wrong to suggest was
there instead of is
. Or perhaps we should log: installing ayz package
since I believe at that point we're just adding it to the list of dependencies.
Perhaps even: Adding package xyz to the dependencies list
plugin-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/AutoInstall.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/AutoInstall.kt
Outdated
Show resolved
Hide resolved
...ild/src/main/kotlin/io/sentry/android/gradle/autoinstall/fragment/FragmentInstallStrategy.kt
Outdated
Show resolved
Hide resolved
...n-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/okhttp/OkHttpInstallStrategy.kt
Outdated
Show resolved
Hide resolved
...n-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/timber/TimberInstallStrategy.kt
Outdated
Show resolved
Hide resolved
Had to revert back to using singleton to share AutoInstallState, cus build services cannot be serialized (and the ComponentMetadataRules are serialized). Did thorough testing - no problems occurred. |
plugin-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/AutoInstall.kt
Show resolved
Hide resolved
...ild/src/main/kotlin/io/sentry/android/gradle/autoinstall/fragment/FragmentInstallStrategy.kt
Outdated
Show resolved
Hide resolved
...n-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/okhttp/OkHttpInstallStrategy.kt
Outdated
Show resolved
Hide resolved
plugin-build/src/main/kotlin/io/sentry/android/gradle/autoinstall/AutoInstallState.kt
Outdated
Show resolved
Hide resolved
@marandaneto addressed the comments, you could take another look if you will. |
#skip-changelog
馃摐 Description
sentryVersion
configuration setting, so the users can specify the version, for instance, if they use an older sentry-android version that is coming as a transitive dependency from one of their submodules/libs.This is what it looks like in practice:
Notice how there are no sentry dependencies in the SS above.
When we build the app, the final apk looks like this (with all integrations and the SDK included):
馃挕 Motivation and Context
Q1 goal
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps