Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requests dependency to the version of 2.22.0 or higher #584

Merged
merged 2 commits into from Sep 6, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

library since a long time requires "urllib3>=1.25.10"
if we looks at requests source code for v2.21.0 https://github.com/psf/requests/releases/tag/v2.21.0

we will see that they require 'urllib3>=1.21.1,<1.25',
https://github.com/psf/requests/blob/5a1e738ea9c399c3f59977f2f98b083986d6037a/setup.py#L47

thus, update our dependency to the higher requests. Docs as well

@beliaev-maksim beliaev-maksim changed the title Update requests dependency to the version of 2.23.0 or higher Update requests dependency to the version of 2.22.0 or higher Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ab17a48) compared to base (6144ef5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #584   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         2730      2730           
=========================================
  Hits          2730      2730           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@markstory markstory merged commit 7318ddd into getsentry:master Sep 6, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/deps branch September 6, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants