-
-
Notifications
You must be signed in to change notification settings - Fork 356
[BETA] replay responses from toml files. #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #581 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 2730 2783 +53
=========================================
+ Hits 2730 2783 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@markstory @chadwhitacre |
Awesome progress, @beliaev-maksim! 😍 |
|
||
assert not self.out_file.exists() | ||
|
||
def test_add_from_file(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think its useful to have test coverage for how fixture files interact with responses that were defined before/after the file was loaded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally, since we only append Responses
, it should be fine as is.
But if I add couple of lines in the test it for sure will not harm :)
Co-authored-by: Mark Story <mark@mark-story.com>
Great job on this @beliaev-maksim 👏 I think we're ready for a release now. |
@markstory |
Any thoughts on when the release will be? We are eagerly awaiting to test the recording functionality! |
closes #40