Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BETA] replay responses from toml files. #581

Merged
merged 3 commits into from Sep 12, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

closes #40

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (80b19ab) compared to base (f431d49).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #581   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         2730      2783   +53     
=========================================
+ Hits          2730      2783   +53     
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/tests/test_recorder.py 100.00% <100.00%> (ø)
responses/tests/test_responses.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@beliaev-maksim
Copy link
Collaborator Author

@markstory @chadwhitacre
historical moment :)
we went down from more than 70 issues last year, to 0, once this PR will be merged and new package is released. Implemented lots of new feature and bug fixes for them :D
Making the library №1 for mocking out requests

@chadwhitacre
Copy link
Member

Awesome progress, @beliaev-maksim! 😍

@beliaev-maksim beliaev-maksim changed the title added beta option for replaying responses from toml files. [BETA] replay responses from toml files. Sep 1, 2022
responses/tests/test_recorder.py Outdated Show resolved Hide resolved

assert not self.out_file.exists()

def test_add_from_file(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think its useful to have test coverage for how fixture files interact with responses that were defined before/after the file was loaded?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally, since we only append Responses, it should be fine as is.
But if I add couple of lines in the test it for sure will not harm :)

@markstory markstory merged commit d4ace43 into getsentry:master Sep 12, 2022
@markstory
Copy link
Member

Great job on this @beliaev-maksim 👏 I think we're ready for a release now.

@beliaev-maksim beliaev-maksim deleted the mbeliaev/reader branch September 12, 2022 14:28
@beliaev-maksim
Copy link
Collaborator Author

@markstory
yes,
all the rest PRs we can push to 0.23

@sanderwilrycx
Copy link

Any thoughts on when the release will be? We are eagerly awaiting to test the recording functionality!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expected response from a file
4 participants