Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust error message when Retry is exhausted #580

Merged
merged 1 commit into from Sep 6, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

@beliaev-maksim beliaev-maksim commented Sep 1, 2022

related to #574

After debugging I found the difference.
When not a raw response is provided, then error message will be too many error responses. While with raw response it is more explicit and mentions the error code: too many 500 error responses

I added tests that cover it.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e7834a2) compared to base (27872a4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #580   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         9    +2     
  Lines         2659      2742   +83     
=========================================
+ Hits          2659      2742   +83     
Impacted Files Coverage Δ
responses/__init__.py 100.00% <ø> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)
responses/_recorder.py 100.00% <0.00%> (ø)
responses/tests/test_recorder.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@markstory markstory merged commit 60931f1 into getsentry:master Sep 6, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/retry_message branch September 6, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants