Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci) Fix lint errors from additional ignores #553

Merged
merged 1 commit into from May 3, 2022
Merged

Conversation

markstory
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #553 (afc8b48) into master (ebf6811) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #553   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2561      2561           
=========================================
  Hits          2561      2561           
Impacted Files Coverage Δ
responses/tests/test_matchers.py 100.00% <ø> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebf6811...afc8b48. Read the comment docs.

@beliaev-maksim
Copy link
Collaborator

beliaev-maksim commented May 3, 2022

that is so weird

I have to add these ignores since it was failing without them, after comments all the checks passed in CI

Now it passes again without comments
why is that?

@markstory
Copy link
Member Author

why is that?

No idea. Is it possible that mypy did a release?

@markstory markstory merged commit 48f2729 into master May 3, 2022
@markstory markstory deleted the fix-lint branch May 3, 2022 17:25
@beliaev-maksim
Copy link
Collaborator

why is that?

No idea. Is it possible that mypy did a release?

that was my first guess. But both current PR and mine use 0.950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants