Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbeliaev/req types #537

Merged
merged 23 commits into from May 3, 2022
Merged

Conversation

beliaev-maksim
Copy link
Collaborator

@beliaev-maksim beliaev-maksim commented Apr 8, 2022

finalize inline types migration. Remove stub file and go with python 3 inline style

closes #552

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #537 (69f12e5) into master (04c9e15) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #537   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2534      2561   +27     
=========================================
+ Hits          2534      2561   +27     
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/matchers.py 100.00% <100.00%> (ø)
responses/tests/test_matchers.py 100.00% <100.00%> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c9e15...69f12e5. Read the comment docs.

@beliaev-maksim beliaev-maksim marked this pull request as ready for review April 11, 2022 17:27
@beliaev-maksim
Copy link
Collaborator Author

@markstory
this was a real hell, still have to keep couple of type ignores.
I think we can handle ignores in another PR, if get a good idea how to fix them, for the moment I am lacking of ideas

also, can we ensure that #469 actually works and we do not get regression
I do not think we did any additional testing to check it

def replace(
self,
method_or_response: Optional[Union[str, BaseResponse]] = None,
url: "Optional[Union[Pattern[str], str]]" = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have type aliases for this and Optional[Union[str, BaseResponse]]? They are both used a few times.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, I added them

@markstory markstory merged commit ebf6811 into getsentry:master May 3, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/req_types branch May 3, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py.typed file not installed by default in setup.cfg
2 participants