New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbeliaev/req types #537
mbeliaev/req types #537
Conversation
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 2534 2561 +27
=========================================
+ Hits 2534 2561 +27
Continue to review full report at Codecov.
|
# Conflicts: # responses/__init__.py
@markstory also, can we ensure that #469 actually works and we do not get regression |
responses/__init__.py
Outdated
def replace( | ||
self, | ||
method_or_response: Optional[Union[str, BaseResponse]] = None, | ||
url: "Optional[Union[Pattern[str], str]]" = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have type aliases for this and Optional[Union[str, BaseResponse]]
? They are both used a few times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, I added them
finalize inline types migration. Remove stub file and go with python 3 inline style
closes #552