Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbeliaev/docs depr #517

Merged
merged 2 commits into from Mar 17, 2022
Merged

Conversation

beliaev-maksim
Copy link
Collaborator

here is look and feel
image

@markstory
do you think we need to add info about removed internals as well?

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #517 (4ca2ce6) into master (1724937) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #517   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2305      2305           
=========================================
  Hits          2305      2305           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1724937...4ca2ce6. Read the comment docs.

@markstory
Copy link
Member

do you think we need to add info about removed internals as well?

I don't think so. Users shouldn't have been using them and I don't think we should be on the hook for them using features that weren't meant to be used.

@markstory markstory merged commit 59330b7 into getsentry:master Mar 17, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/docs_depr branch March 17, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants