Fixed the issue when reset() method was called in not stopped mock
#516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #516 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2305 2315 +10
=========================================
+ Hits 2305 2315 +10
Continue to review full report at Codecov.
|
potiuk
approved these changes
Mar 17, 2022
bblommers
approved these changes
Mar 17, 2022
markstory
reviewed
Mar 17, 2022
responses/tests/test_responses.py
Outdated
| with responses.RequestsMock() as rsps2: | ||
| rsps2.reset() | ||
| responses.add(responses.GET, "https://example.invalid", status=200) | ||
| print(requests.request("GET", "https://example.invalid")) |
There was a problem hiding this comment.
@markstory
confirm that
# Conflicts: # CHANGES
beliaev-maksim
force-pushed
the
mbeliaev/fix_511
branch
from
658c0e8
to
f1e38e4
Compare
beliaev-maksim
force-pushed
the
mbeliaev/fix_511
branch
from
f1e38e4
to
42415ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #511
Fix the issue - one line of code, know where to fix the issue - 1.5h :D
explanation:
when reset in the middle, we clean up
_patcherwhich is a req for another issue. But when we do it, it prevents patcher to be stopped.In PR test case actual mock is applied from
rsps2instead ofresponses.mockbecause we did not clean up patcher on exit from the context manager