Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change logic of _get_url_and_path to comply with RFC 3986 #507

Merged
merged 2 commits into from Mar 4, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

closes #506

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #507 (179bda0) into master (a35896e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #507   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2200      2208    +8     
=========================================
+ Hits          2200      2208    +8     
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/test_responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a35896e...179bda0. Read the comment docs.

@markstory markstory merged commit e4337d6 into getsentry:master Mar 4, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/url_path branch March 4, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path segment parameters not handled correctly
2 participants