Add logging of passthrus when there's no match #505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes related to passthrus:
responses.passthru_prefixes
is always empty because it is a value type that is captured when the responses module is loaded. I've fixed this by making passthru_prefixes a mutable list. Of course, this will allow users to add things directly to the list. The downsides of this seem minimal, but I'm happy to fix this in another way if we think it's important to maintain immutability.I also added some logging of passthrus when there is no match. I found this helpful for debugging.