mbeliaev/patcher #500
Merged
mbeliaev/patcher #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2162 2178 +16
=========================================
+ Hits 2162 2178 +16
Continue to review full report at Codecov.
|
markstory
reviewed
Feb 16, 2022
responses/__init__.py
Outdated
| @@ -809,11 +810,16 @@ def start(self): | |||
| def unbound_on_send(adapter, request, *a, **kwargs): | |||
| return self._on_request(adapter, request, *a, **kwargs) | |||
|
|
|||
| self._patcher = std_mock.patch(target=self.target, new=unbound_on_send) | |||
| self._patcher.start() | |||
| if not self._patcher: | |||
There was a problem hiding this comment.
Should the function on line 810 only be defined when we're creating a patcher as well?
There was a problem hiding this comment.
confirm, let's save some runtime on it and just return if patcher already exists
|
Wow, thanks for fixing this 🥳 |
This was referenced Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #481
that was a tricky one, after research I found the root cause. Since default decorator always uses
mock = _default_mock, when we apply double patching, we override the value of the_patcher. When standard pythonmockis trying to stop the patcher, it fails, since we have another object in the memory.Keeping only single
mockfor all nested functions is sufficient enough. Thus, prevent from override and do clean up on the__exit__.