mbeliaev/loose matcher #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2162 2184 +22
=========================================
+ Hits 2162 2184 +22
Continue to review full report at Codecov.
|
|
tests fail, #495 should fix it |
beliaev-maksim
force-pushed
the
mbeliaev/loose_matcher
branch
from
5cc62fe
to
c6d0114
Compare
markstory
reviewed
Feb 16, 2022
responses/matchers.py
Outdated
|
|
||
| if not valid: | ||
| reason = "Parameters do not match. {} doesn't match {}".format( | ||
| _create_key_val_str(request_params_dict), | ||
| _create_key_val_str(params_dict), | ||
| ) | ||
| if not strict_match: | ||
| reason += "\nNote that you use not strict parameters check." |
There was a problem hiding this comment.
Suggested change
| reason += "\nNote that you use not strict parameters check." | |
| reason += "\nYou can use `strict_match=False` to use enable matches." |
What do you think of this? It makes the error more instructive on what a next step could be.
There was a problem hiding this comment.
agree with the idea, but I think the message should be "You can use 'strict_match=True' to do a strict parameters check."
since now this reason is triggered when strict_match=False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #496