Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: wrap passthru inside another mock #495

Merged
merged 2 commits into from Feb 9, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

I still see the issue in pipeline

https://github.com/getsentry/responses/runs/5112676859?check_suite_focus=true

I think wrap _real_send will resolve the issue. Basically, only when _real_send is called we mock it, that ensures that passthru worked.

@markstory
objections ?

@beliaev-maksim beliaev-maksim changed the title wrap passthru inside another mock tests: wrap passthru inside another mock Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #495 (6b5795a) into master (930b784) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #495   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2161      2162    +1     
=========================================
+ Hits          2161      2162    +1     
Impacted Files Coverage Δ
responses/test_responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930b784...6b5795a. Read the comment docs.

@markstory markstory merged commit 4c4b46b into getsentry:master Feb 9, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/fix_test branch February 9, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants