Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raven.extra_context no longer returns tags (regression in v2.12.0) #931

Closed
matt-thomson opened this issue Oct 17, 2019 · 3 comments
Closed

Raven.extra_context no longer returns tags (regression in v2.12.0) #931

matt-thomson opened this issue Oct 17, 2019 · 3 comments

Comments

@matt-thomson
Copy link

Previously, the return value from Raven.extra_context was the set of tags that were in the context. However, since #920, this method now returns nil.
@tycooon tycooon mentioned this issue Oct 17, 2019
Merged
rivayama added a commit to rivayama/raven-ruby that referenced this issue Oct 21, 2019
@rivayama
fix: return tags/extra for getsentry#931
167d023
@rivayama rivayama mentioned this issue Oct 21, 2019
Merged
@rivayama
Copy link
Contributor

Created a PR to fix this issue #933, sorry for the inconvenience 🙇

HazAT pushed a commit that referenced this issue Oct 24, 2019
@rivayama @HazAT
fix: return tags/extra for #931 (#933)
7121d3c
@rivayama
Copy link
Contributor

The fix has got merged and then released in v2.12.2 🙏

@matt-thomson
Copy link
Author

Many thanks @rivayama! This is working for us.

@jarthod jarthod mentioned this issue Oct 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matt-thomson @rivayama