Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine readme #1366

Merged
merged 7 commits into from
Mar 26, 2021
Merged

Refine readme #1366

merged 7 commits into from
Mar 26, 2021

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Mar 26, 2021

The readme now has a full list of all the SDK gems with a link to the change log. It also looks better imo 😉

@st0012 st0012 added this to the sentry-ruby-4.3.2 milestone Mar 26, 2021
@st0012 st0012 added this to In progress in 4.x via automation Mar 26, 2021
@st0012 st0012 self-assigned this Mar 26, 2021
@codecov-io
Copy link

codecov-io commented Mar 26, 2021

Codecov Report

Merging #1366 (fa601ce) into master (86dcf3c) will decrease coverage by 10.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1366       +/-   ##
===========================================
- Coverage   98.08%   87.26%   -10.82%     
===========================================
  Files         208       38      -170     
  Lines        9173     1154     -8019     
===========================================
- Hits         8997     1007     -7990     
+ Misses        176      147       -29     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/integrable.rb 0.00% <0.00%> (-100.00%) ⬇️
sentry-sidekiq/lib/sentry-sidekiq.rb 0.00% <0.00%> (-100.00%) ⬇️
sentry-sidekiq/lib/sentry/sidekiq/error_handler.rb 0.00% <0.00%> (-100.00%) ⬇️
...entry-sidekiq/lib/sentry/sidekiq/context_filter.rb 0.00% <0.00%> (-100.00%) ⬇️
...iq/lib/sentry/sidekiq/sentry_context_middleware.rb 0.00% <0.00%> (-100.00%) ⬇️
sentry-rails/spec/sentry/rails/client_spec.rb 6.45% <0.00%> (-93.55%) ⬇️
sentry-rails/app/jobs/sentry/send_event_job.rb 61.11% <0.00%> (-16.67%) ⬇️
...ls/lib/sentry/rails/tracing/abstract_subscriber.rb 84.61% <0.00%> (-11.54%) ⬇️
sentry-rails/lib/sentry/rails/active_job.rb 96.96% <0.00%> (-0.18%) ⬇️
sentry-rails/lib/sentry/rails/configuration.rb 100.00% <0.00%> (ø)
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86dcf3c...fa601ce. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

4.x automation moved this from In progress to Reviewer approved Mar 26, 2021
@st0012 st0012 merged commit f23e980 into master Mar 26, 2021
4.x automation moved this from Reviewer approved to Done Mar 26, 2021
@st0012 st0012 deleted the add-gems-table branch March 26, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants