Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

feat: log non-standard ports in breadcrumbs #440

Merged
merged 1 commit into from
Apr 4, 2018
Merged

feat: log non-standard ports in breadcrumbs #440

merged 1 commit into from
Apr 4, 2018

Conversation

kamilogorek
Copy link
Contributor

It makes perfect sens for me.

Resolves: #439

@kamilogorek kamilogorek requested a review from a team March 23, 2018 09:31
billyvg
billyvg approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need tests that show :80/:443 get stripped?

@kamilogorek
Copy link
Contributor Author

kamilogorek commented Mar 23, 2018 •
edited

@billyvg we do have them. should instrument http to capture breadcrumbs and should instrument https to capture breadcrumbs are covering these cases, as nock is using :80/:443 by default.

@kamilogorek kamilogorek merged commit ccb38cf into master Apr 4, 2018
@kamilogorek kamilogorek deleted the log-nonstandard-port branch April 4, 2018 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamilogorek @billyvg