Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSN to Dsn casing change #1503

Merged
merged 2 commits into from
Sep 3, 2018
Merged

DSN to Dsn casing change #1503

merged 2 commits into from
Sep 3, 2018

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Sep 3, 2018

2efd853 only this commit introduces any changes. The first one is just find and replace.

@kamilogorek kamilogorek changed the title Dsn updates DSN to Dsn casing change Sep 3, 2018
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, why is one test failing 😬 ?

@@ -30,7 +30,7 @@ export const defaultIntegrations = [
* const { init } = require('@sentry/node');
*
* init({
* dsn: '__DSN__',
* dsn: '__Dsn__',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This should be caps. Not that it matters but in the docs it's also caps.

@kamilogorek kamilogorek merged commit f25fb26 into master Sep 3, 2018
@kamilogorek
Copy link
Contributor Author

I'll update with next PR

@kamilogorek kamilogorek deleted the dsn-updates branch September 3, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants