Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Raven.setUserContext typescript definition. #1500

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

fabien0102
Copy link
Contributor

The Raven.setUserContext is actually very permissive so any may be a better option here.

Additionally you can provide arbitrary key/value pairs beyond the reserved names and those will be stored with the user.

https://docs.sentry.io/learn/context/#capturing-the-user

Note: I tried the actual tested payload on sentry, and I have the data perfectly display 馃槈

@fabien0102
Copy link
Contributor Author

From travis:

Running "config:ci" task
No SAUCE_USERNAME env variable defined.
No SAUCE_ACCESS_KEY env variable defined.

I don't think that it's link to my PR 馃

This setUserContext is actually very permissive so `any` may be a better option here.
@codecov-io
Copy link

Codecov Report

Merging #1500 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   72.61%   72.55%   -0.07%     
==========================================
  Files          41       41              
  Lines        1249     1246       -3     
  Branches      239      238       -1     
==========================================
- Hits          907      904       -3     
  Misses        333      333              
  Partials        9        9
Impacted Files Coverage 螖
packages/utils/src/supports.ts 42.1% <0%> (-4.24%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d54c762...031bf76. Read the comment docs.

@kamilogorek kamilogorek merged commit 551d597 into getsentry:master Sep 4, 2018
@kamilogorek
Copy link
Contributor

Thanks!

@fabien0102
Copy link
Contributor Author

@kamilogorek Thanks for your review 馃挴
When can we have this available on npm? (I have a as any that I want to remove 馃槃 )

@kamilogorek
Copy link
Contributor

@fabien0102 https://www.npmjs.com/package/raven-js/v/3.27.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants