Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove keepalive:true as a default and document payload size #1496

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Aug 28, 2018

Fixes: #1470
Fixes: #1464
Fixes: #339

Re: getsentry/sentry-docs#310

@HazAT
Copy link
Member

HazAT commented Aug 31, 2018

For new SDKs it's here: #1497

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw docs are gone, you need to change it in the docs repo.
Also we should not forget when we release raven-js we need to update bower also.

@codecov-io
Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #1496 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1496   +/-   ##
=======================================
  Coverage   72.79%   72.79%           
=======================================
  Files          42       42           
  Lines        1283     1283           
  Branches      242      242           
=======================================
  Hits          934      934           
  Misses        341      341           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 551021f...1798bda. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants