fix: Always pass request through parseRequest for raven-node #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1404 +/- ##
=======================================
Coverage 88.09% 88.09%
=======================================
Files 31 31
Lines 697 697
Branches 105 105
=======================================
Hits 614 614
Misses 78 78
Partials 5 5Continue to review full report at Codecov.
|
HazAT
approved these changes
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1399
When someone attached a request using
Raven.setContext({ request })and it didn't follow our http interface https://docs.sentry.io/clientdev/interfaces/http/ it caused a very bad time forstringifyfunction, as it may contain 92830 of references to external objects.