feat: SDK unified API #1402
Merged
feat: SDK unified API #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
requested changes
Jun 19, 2018
packages/hub/src/hub.ts
Outdated
| */ | ||
| public addEventProcessor(callback: () => (event: SentryEvent) => void): void { | ||
| const top = this.getStackTop(); | ||
| if (top.scope) { |
packages/hub/src/global.ts
Outdated
| * | ||
| * If a hub is already registered in the global carrier but this module | ||
| * contains a more recent version, it replaces the registered version. | ||
| * Otherwise, the currently registered hub will be returned. | ||
| */ | ||
| export function getGlobalHub(): Hub { | ||
| const registry = getGlobalCarrier(); | ||
| export function getMainHub(): Hub { |
There was a problem hiding this comment.
If it returns domain local data it should be getDefaultHub.
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
+ Coverage 88.09% 88.73% +0.63%
==========================================
Files 31 31
Lines 697 701 +4
Branches 105 105
==========================================
+ Hits 614 622 +8
+ Misses 78 74 -4
Partials 5 5
Continue to review full report at Codecov.
|
mitsuhiko
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the SDK unification paper conform