Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose getDefaultIntegrations to use in other sdks #1393

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jun 13, 2018

In sentry-cordova we need to be able to overwrite/use the browser default integrations so we need to expose them. Same is probably valid for sentry-electron later.

@HazAT HazAT requested a review from kamilogorek as a code owner June 13, 2018 11:41
@HazAT HazAT self-assigned this Jun 13, 2018
@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #1393 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1393      +/-   ##
=========================================
+ Coverage   73.53%   73.6%   +0.07%     
=========================================
  Files          31      31              
  Lines         699     701       +2     
  Branches      104     104              
=========================================
+ Hits          514     516       +2     
  Misses        182     182              
  Partials        3       3
Impacted Files Coverage Δ
packages/node/src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fec973...02c9015. Read the comment docs.

@HazAT HazAT force-pushed the feature/expose-default-integrations branch from 4fc4d09 to 46354dd Compare June 13, 2018 13:53
@HazAT HazAT merged commit 5317a75 into master Jun 14, 2018
@HazAT HazAT deleted the feature/expose-default-integrations branch June 14, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants