Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce hub #1364

Merged
merged 14 commits into from
Jun 13, 2018
Merged

feat: Introduce hub #1364

merged 14 commits into from
Jun 13, 2018

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jun 11, 2018

This should be ready to review, besides the Coverage (which is caused by integrations) this should work just fine.

@HazAT HazAT self-assigned this Jun 11, 2018
@HazAT HazAT requested a review from kamilogorek as a code owner June 11, 2018 12:16
@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #1364 into master will decrease coverage by 11.23%.
The diff coverage is 48.79%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1364       +/-   ##
===========================================
- Coverage   84.77%   73.53%   -11.24%     
===========================================
  Files          31       31               
  Lines         742      699       -43     
  Branches      110      104        -6     
===========================================
- Hits          629      514      -115     
- Misses        109      182       +73     
+ Partials        4        3        -1
Impacted Files Coverage Δ
packages/core/src/base.ts 100% <ø> (+1.25%) ⬆️
packages/core/test/mocks/client.ts 91.66% <ø> (ø) ⬆️
packages/core/src/sdk.ts 93.75% <ø> (ø) ⬆️
packages/core/test/mocks/backend.ts 100% <ø> (ø) ⬆️
packages/minimal/test/mocks/client.ts 100% <100%> (ø)
packages/node/src/integrations/http.ts 54% <100%> (ø) ⬆️
packages/node/src/integrations/console.ts 91.66% <100%> (ø) ⬆️
packages/hub/src/index.ts 100% <100%> (ø)
packages/node/src/index.ts 100% <100%> (ø) ⬆️
packages/node/src/sdk.ts 87.5% <100%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa938c...3f35c95. Read the comment docs.

@HazAT HazAT changed the title [WIP] feat: Introduce hub feat: Introduce hub Jun 12, 2018
@HazAT HazAT requested a review from mitsuhiko June 12, 2018 12:08
@HazAT HazAT merged commit 4fec973 into master Jun 13, 2018
@HazAT HazAT deleted the feature/shim-hub branch June 13, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants