Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no sanity check for PAGINATED_TEMPLATES #2757

Open
galaxy4public opened this issue May 21, 2020 · 3 comments
Open

no sanity check for PAGINATED_TEMPLATES #2757

galaxy4public opened this issue May 21, 2020 · 3 comments
Assignees

Comments

@galaxy4public
Copy link
Contributor

I think this is an oversight when PAGINATED_DIRECT_TEMPLATES was deprecated in favour of PAGINATED_TEMPLATES. The settings.py file has a sanity check:

https://github.com/getpelican/pelican/blob/master/pelican/settings.py#L633

but for some reason it checks the deprecated option only.

I would expect either both options to be checked there or just the new one.

@avaris
Copy link
Member

avaris commented May 21, 2020

New setting doesn't fit into that warning (PAGINATED_TEMPLATES is a dict), but yes it can be removed from the check. Deprecation handling code will remove it from settings before that check.

@stale
Copy link

stale bot commented Jul 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your participation and understanding.

@stale stale bot added the stale Marked for closure due to inactivity label Jul 20, 2020
@justinmayer
Copy link
Member

@galaxy4public / @avaris: In the interest of clarity, what exactly do you think is the best way to proceed here?

@stale stale bot removed the stale Marked for closure due to inactivity label Jul 23, 2020
@avaris avaris self-assigned this Jul 23, 2020
@justinmayer justinmayer removed the bug label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants