From 81ce39e9e6dba51d595d04f48e4e0e39135957d3 Mon Sep 17 00:00:00 2001 From: Shouhei Nishi Date: Tue, 13 Dec 2022 17:14:50 +0900 Subject: [PATCH] Change TestIssue542 and TestIssue615 --- openapi3/issue542_test.go | 3 +-- openapi3/issue615_test.go | 10 ++-------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/openapi3/issue542_test.go b/openapi3/issue542_test.go index 7e0cb88c9..4ba017aed 100644 --- a/openapi3/issue542_test.go +++ b/openapi3/issue542_test.go @@ -10,6 +10,5 @@ func TestIssue542(t *testing.T) { sl := NewLoader() _, err := sl.LoadFromFile("testdata/issue542.yml") - require.Error(t, err) - require.Contains(t, err.Error(), CircularReferenceError) + require.NoError(t, err) } diff --git a/openapi3/issue615_test.go b/openapi3/issue615_test.go index ceb317ab0..e7bd01e92 100644 --- a/openapi3/issue615_test.go +++ b/openapi3/issue615_test.go @@ -9,17 +9,11 @@ import ( ) func TestIssue615(t *testing.T) { - for { + { loader := openapi3.NewLoader() loader.IsExternalRefsAllowed = true _, err := loader.LoadFromFile("testdata/recursiveRef/issue615.yml") - if err == nil { - continue - } - // Test currently reproduces the issue 615: failure to load a valid spec - // Upon issue resolution, this check should be changed to require.NoError - require.Error(t, err, openapi3.CircularReferenceError) - break + require.NoError(t, err) } var old int