Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alex transitively depends on got that has a security problem #333

Closed
julienw opened this issue Nov 2, 2022 · 4 comments · Fixed by #334
Closed

alex transitively depends on got that has a security problem #333

julienw opened this issue Nov 2, 2022 · 4 comments · Fixed by #334

Comments

@julienw
Copy link
Contributor

julienw commented Nov 2, 2022

Subject of the issue

Here is the details of this security advisory:
Got allows a redirect to a UNIX socket
Package: got
Patched in: >=11.8.5
Path: alex > update-notifier > latest-version > package-json > got
More info: https://www.npmjs.com/advisories/1080920

My understanding is that package-json doesn't use the option followRedirect and therefore isn't vulnerable to this issue. Still having to look at this manually is painful, and it would be much easier if alex could update its dependency to update-notifier (they upgraded the bad dependency in yeoman/update-notifier#222).

Thanks

@wooorm
Copy link
Member

wooorm commented Nov 2, 2022

It’s not an issue. Microsoft/GitHub/npm is lying to you: https://overreacted.io/npm-audit-broken-by-design/.

@julienw
Copy link
Contributor Author

julienw commented Nov 2, 2022

Note that that's exactly what I wrote.
However having that every user look at the potentially offending code themselves is more work than just upgrading once and for alll the dependency in alex.
Let's remember that alex gets run on the developer machine, therefore security issues can still be real issues even though it's "just" a development dependency.

@wooorm
Copy link
Member

wooorm commented Nov 2, 2022

It’s a lot of work for me to maintain lots of packages.

My point isn‘t about development dependencies. This particular vulnerability is not a vulnerability for users of alex.

@julienw
Copy link
Contributor Author

julienw commented Nov 2, 2022

I can suggest to set up a service such as depfu.com, this has been a great help in our project to manage dependencies.

Also I'd be happy to do PRs to update dependencies in these cases too, given I'm the one who cares about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants