fix: replace monaco CDN loader with npm package #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiVolland
reviewed
Aug 22, 2023
| @@ -33,7 +33,32 @@ import React, { | |||
| useState | |||
| } from 'react'; | |||
|
|
|||
| import Editor, { useMonaco } from '@monaco-editor/react'; | |||
| import * as monaco from 'monaco-editor'; | |||
There was a problem hiding this comment.
Suggested change
| import * as monaco from 'monaco-editor'; | |
| import monaco from 'monaco-editor'; |
should work too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes use of the monaco loader and configs provided via npm. By default, the editor requests those via http requests to a CDN. Now, everything is included in the build, so no more requests will be sent.
See also https://github.com/suren-atoyan/monaco-react#use-monaco-editor-as-an-npm-package.
Fixes #2345
Do you introduce a breaking change?