Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geostyler sends request to online cdn #2345

Open
vahidbabaveisi opened this issue Aug 15, 2023 · 5 comments · May be fixed by #2346
Open

Geostyler sends request to online cdn #2345

vahidbabaveisi opened this issue Aug 15, 2023 · 5 comments · May be fixed by #2346
Assignees
Labels
bug Something isn't working

Comments

@vahidbabaveisi
Copy link

Description

Hello,

I contfront with a problem, I developed my react app using geostyler. Everything is ok when we work online, but as we are offline, geostyler app stops working since it sends request to https://cdn.jsdelivr.net/npm/monaco-editor@0.36.1/min/vs/loader.js for loading monaco editor. I can not solve this. Please help me.

Expected behaviour

I expect that when we build react app, It works stand alone even when we are offline.

How to reproduce

Web browser-react app

Possible Solution

No response

Additional Context

No response

@vahidbabaveisi vahidbabaveisi added the bug Something isn't working label Aug 15, 2023
@KaiVolland
Copy link
Collaborator

Unfortunately this request is done by the monaco editor. But you can try to overwrite this handling: https://github.com/suren-atoyan/monaco-react#use-monaco-editor-as-an-npm-package.

@jansule
Copy link
Contributor

jansule commented Aug 15, 2023

I think this is something that needs to be adjusted in GeoStyler itself and not in applications using GeoStyler. We should check, if there is a way to circumvent this. Maybe the link provided is already what we need.

@vahidbabaveisi
Copy link
Author

Thanks @KaiVolland . It solved my problem. Now, it is fully stand-alone and works without any connection to the internet. You suvived me!

@jansule jansule linked a pull request Aug 18, 2023 that will close this issue
3 tasks
Copy link

This issue is stale because it has been open for 180 days with no activity. Feel free to unstale it at any time by adding a comment.

@github-actions github-actions bot added the stale label Feb 12, 2024
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale. Feel free to reopen it at any time, if this issue is still relevant.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
@jansule jansule reopened this Feb 26, 2024
@github-actions github-actions bot removed the stale label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants