Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLD Renderer shows a resized smaller image in compact mode #1745

Open
ocruze opened this issue Jun 10, 2022 · 1 comment
Open

SLD Renderer shows a resized smaller image in compact mode #1745

ocruze opened this issue Jun 10, 2022 · 1 comment
Assignees
Labels
bug Something isn't working permanent Deactivate Stale Bot for this issue

Comments

@ocruze
Copy link
Member

ocruze commented Jun 10, 2022

Bug

Describe the bug
The size of the symbols rendered by the SLDRenderer and Renderer is different in the geostyler editor in the compact mode. This is probably due to the fact that Renderer is showing a openlayers map and the SLDRenderer is showing an img in a div which is being resized to the size of the div.

To Reproduce
Steps to reproduce the behavior:

  1. Checkout and go to the geostyler-demo home page
  2. Make sure you are in the compact mode
  3. Add a mark symbol, a circle for example (choose a size and colour)
  4. Switch between the openlayers and SLD renderer to see the difference
  5. Finally, switch to the expanded mode, the SLDRenderer is showing the correct size of the img

Expected behavior
The size of the symbols rendered by the both SLDRenderer and Renderer should be of same size.

Screenshots
Compact Mode, SLDRenderer:
image

Compact Mode, Renderer:
image

Expanded Mode, SLDRenderer:
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox

Possible solution
Instead of an img in a div, we could try to set the image as the background-image of the div. This would also give us the possibility of cropping the img if it's too large, which is the case of Renderer.

@ocruze ocruze added the bug Something isn't working label Jun 10, 2022
@github-actions
Copy link

This issue is stale because it has been open for 180 days with no activity.

@github-actions github-actions bot added the stale label Dec 17, 2022
@jansule jansule added permanent Deactivate Stale Bot for this issue and removed stale labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working permanent Deactivate Stale Bot for this issue
Projects
None yet
Development

No branches or pull requests

3 participants