-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursor position is shifted incorrectly in Localized number field component #10289
Closed
1 task done
Comments
12 tasks
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 13, 2024
…lized number field component Description: - fix the jumping cursor to unexpected positions for localized numeric input
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 13, 2024
…lized number field component Description: - replace logic in updateDidMount to onKeyUp - remove unused comments
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 13, 2024
…lized number field component Description: - remove unused method in IntlNumberFormControl
12 tasks
12 tasks
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 16, 2024
…lized number field component [resolve review comments] Description: - fix issue of on focus effect in NumericInput
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 16, 2024
…lized number field component [resolve review comments] Description: - fix FE issue in onKeyDown in IntlNumberFormControl
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 16, 2024
…lized number field component [resolve review comments] Description: - revert unnecessary change
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 16, 2024
…lized number field component [resolve review comments] Description: - move the fixing logic of cursor position to componentDidUpdate instead of onKeyUp
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 17, 2024
…lized number field component [resolve review comments] Description: - add onKeyUp as a prop into IntlNumberFormControl for any expected future consuming from a parent comp
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 17, 2024
…lized number field component [resolve review comments] Description: - add unit test - resolve review comments
dsuren1
pushed a commit
that referenced
this issue
May 20, 2024
…eld component (#10312) * #10289: Cursor position is shifted incorrectly in Localized number field component Description: - fix the jumping cursor to unexpected positions for localized numeric input * #10289: Cursor position is shifted incorrectly in Localized number field component Description: - replace logic in updateDidMount to onKeyUp - remove unused comments * #10289: Cursor position is shifted incorrectly in Localized number field component Description: - remove unused method in IntlNumberFormControl * #10136: Search for Map CRS coordinates Description: - resolve FE failure in unit test * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - fix issue of on focus effect in NumericInput * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - fix FE issue in onKeyDown in IntlNumberFormControl * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - revert unnecessary change * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - move the fixing logic of cursor position to componentDidUpdate instead of onKeyUp * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - add onKeyUp as a prop into IntlNumberFormControl for any expected future consuming from a parent comp * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - add unit test - resolve review comments
ElenaGallo
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
May 20, 2024
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this issue
May 21, 2024
…lized number field component (geosolutions-it#10312) * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component Description: - fix the jumping cursor to unexpected positions for localized numeric input * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component Description: - replace logic in updateDidMount to onKeyUp - remove unused comments * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component Description: - remove unused method in IntlNumberFormControl * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve FE failure in unit test * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - fix issue of on focus effect in NumericInput * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - fix FE issue in onKeyDown in IntlNumberFormControl * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - revert unnecessary change * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - move the fixing logic of cursor position to componentDidUpdate instead of onKeyUp * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - add onKeyUp as a prop into IntlNumberFormControl for any expected future consuming from a parent comp * geosolutions-it#10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - add unit test - resolve review comments
dsuren1
pushed a commit
that referenced
this issue
May 21, 2024
…eld component (#10312) (#10346) * #10289: Cursor position is shifted incorrectly in Localized number field component Description: - fix the jumping cursor to unexpected positions for localized numeric input * #10289: Cursor position is shifted incorrectly in Localized number field component Description: - replace logic in updateDidMount to onKeyUp - remove unused comments * #10289: Cursor position is shifted incorrectly in Localized number field component Description: - remove unused method in IntlNumberFormControl * #10136: Search for Map CRS coordinates Description: - resolve FE failure in unit test * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - fix issue of on focus effect in NumericInput * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - fix FE issue in onKeyDown in IntlNumberFormControl * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - revert unnecessary change * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - move the fixing logic of cursor position to componentDidUpdate instead of onKeyUp * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - add onKeyUp as a prop into IntlNumberFormControl for any expected future consuming from a parent comp * #10289: Cursor position is shifted incorrectly in Localized number field component [resolve review comments] Description: - add unit test - resolve review comments
ElenaGallo
added
Accepted
and removed
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
labels
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Current localized number field component exhibits certain behavior which makes it editing field values a bit complex
Note
Works fine which mouse selection though
How to reproduce
Expected Result
Cursor position is retained correctly when editing value in a localized number field
Current Result
Cursor position is shifted incorrectly when editing values in-between number i.e on change value or any keyboard action like (ctrl+a) and text selection is not retained
Browser info
(use this site: https://www.whatsmybrowser.org/ for non expert users)Other useful information
The text was updated successfully, but these errors were encountered: