Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend filter is persisted while editing a style causing inconsistencies #10236

Open
1 task done
allyoucanmap opened this issue Apr 23, 2024 · 0 comments
Open
1 task done

Comments

@allyoucanmap
Copy link
Contributor

Description

The legend filter is not removed while editing a style of a WMS layer with the visual style editor, this can cause incosistency in the following cases:

  • selection of a different style (internal editing)
  • editing of the selected style and changing the rule with the visual style editor (internal editing)
  • creation of a new style with the visual style editor (internal editing)
  • external editing of a style (eg. on GeoServer) (external editing)

For all the internal editing we should intercept the events and correctly update the layer (it could be helpfull to take a look to the styleeditor epic where all the style editor logic is implemented).

For external cases I think we need a message inside the Legend component itself to let the user know that something is not aligned and a button to reset the legend filters

Important: the legend filter is part of the layerFilter that could have similar inconsistency problems so it's important to evaluate this task taking into account the whole property

What kind of improvement you want to add? (check one with "x", remove the others)

  • Investigation

Other useful information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants