Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Epic Test with two services is flaky #10175

Open
1 task done
fkellner opened this issue Apr 8, 2024 · 0 comments · May be fixed by #10176
Open
1 task done

Search Epic Test with two services is flaky #10175

fkellner opened this issue Apr 8, 2024 · 0 comments · May be fixed by #10176
Labels

Comments

@fkellner
Copy link
Contributor

fkellner commented Apr 8, 2024

Description

The search epic test "produces the search epic with two services with more results than default limit" loads two result files:
Wyoming (containing ids states.x) and Arizona (containing ids states-ari.x).

It then tests that the combined limited search always produces 5 results from the Wyoming file, even after both services have loaded. However, which service source produces results first seems to be non-deterministic and differ between MacOS and Windows, with the test running on MacOS failing because the Arizona file loads first sometimes.

How to reproduce

Run the search-test on MacOS.

Expected Result

The test to run through.

Current Result

The test "produces the search epic with two services with more results than default limit" fails because it receives states-ari.1 instead of states.1.

  • Not browser related

Other useful information

We already fixed this in our version by

  • setting a different priority for the services
  • accepting results from either file in the first emitted result action
  • only accepting results from the file with higher priority in the second result action

but forgot to play it back. Will open a PR shortly.

@fkellner fkellner added the bug label Apr 8, 2024
fkellner pushed a commit to fkellner/MapStore2 that referenced this issue Apr 8, 2024
Apparently, which search service observable emits results first does not depend on the order
in which they are passed into the search. The test however assumed there to be an
order, causing it to break on MacOS. This is now fixed.

On Behalf of DB Systel
@tdipisa tdipisa linked a pull request Apr 8, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant